Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Update psql helper #657

Merged
merged 21 commits into from Mar 9, 2019

Conversation

Projects
None yet
4 participants
@kay0u
Copy link
Contributor

commented Feb 20, 2019

The problem

...

Solution

Update psql helper

PR Status

Tested in local. I spotted a silent error when restore a database from a file ynh_psql_connect_as $db_name $db_pwd $db_name < ./db.sql but already present with the old version:
"ERROR: must be owner of extension plpgsql"

I think I've fixed that

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

kay0u added some commits Feb 18, 2019

Show resolved Hide resolved data/helpers.d/psql Outdated
Show resolved Hide resolved data/helpers.d/psql Outdated
Show resolved Hide resolved data/helpers.d/psql Outdated
Show resolved Hide resolved data/helpers.d/psql Outdated

kay0u added some commits Feb 20, 2019

@kay0u

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

Need another review now :-)

I tested with lstu (on testing branch). So: Create user/db, dump, restore, remove user/db and i have not noticed any problem

Show resolved Hide resolved data/helpers.d/psql Outdated
Show resolved Hide resolved data/helpers.d/psql Outdated

kay0u added some commits Feb 21, 2019

Show resolved Hide resolved data/helpers.d/psql Outdated

kay0u added some commits Feb 21, 2019

@Josue-T

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Why did you change the order of the helper, it make the change really difficult to review :-/

@kay0u

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

Sorry, it was more convenient for me to compare with MySQL helper, but for reviewers it's a lot harder. I can rearrange the code as before

Show resolved Hide resolved data/helpers.d/psql Outdated
Show resolved Hide resolved data/helpers.d/psql Outdated

kay0u added some commits Feb 21, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

Sooo, are we good with this ? (Did anybody test those ?)

@kay0u

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2019

I tested everything but ynh_psql_execute_file_as_root (I don't really know how to use it).

You can install/restore lstu to test this helper

@alexAubin alexAubin added this to the 3.5.x milestone Feb 25, 2019

@alexAubin
Copy link
Member

left a comment

Not tested, but made a quick review and LGTM

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Would be interesting to have some feedback from people who are actually using that postgres in apps.
Otherwise, that's look good to me.
Anyway, can't be worse than the current version...

@alexAubin

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Soooo flagging this as ready to merge, will merge in a few days if there's no complain since then

@alexAubin alexAubin merged commit 2d086c4 into YunoHost:stretch-unstable Mar 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kay0u kay0u deleted the kay0u:patch-2 branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.