Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apt-transport-https to dependencies #658

Merged
merged 1 commit into from Feb 23, 2019

Conversation

Projects
None yet
3 participants
@alexAubin
Copy link
Member

commented Feb 20, 2019

The problem

c.f. YunoHost/issues#1242

apt-transport-https is installed in many setups because it's installed via the install-script, but it's not in the yunohost dependencies so not installed on x86 ISO. Therefore, packagers don't realize this and this later breaks install for some user who don't have apt-transport-https installed.

From what I understand, this is related to the whole question of wether or not to add additional repo. Not sure what to do exactly but it sounds to me that sometimes it can't really be avoided ... Anyway this is kinda independent, and I think for the "additional repo" thing we could add a warning in package linter or something. (My opinion is that we should have helpers / core stuff to help integrating additional repos in a clean way)

Solution

Add apt-transport-https to core dependencies

PR Status

Yolocommited

How to test

Uh compile the whole debian package and install it on a fresh debian but meh not sure we really need to test this

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@JimboJoe
Copy link
Member

left a comment

LGTM 👍

@alexAubin alexAubin merged commit a643e62 into stretch-unstable Feb 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the add-apt-transport-https branch Feb 23, 2019

@alexAubin alexAubin referenced this pull request Feb 23, 2019

Closed

add apt-transport-https #1242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.