Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[fix] Optimize dyndns requests #662
c.f. YunoHost/issues#1300 - unecessary madness which makes everything slower (dyndns update taking the lock every 2 minutes to do a full HTTPS request for nothing and therefore dynette is bombarded with those and sometimes aint able to answer)
Don't make all those crazy request, not really necessary ... Also add some constrains to try to remove ambiguities
Yolocommited, not tested :|
How to test
Try this on a server with a registered nohost.me/noho.st/... Try to subscribe multiple time. Try a case where subscribing failed to see if keys are indeed removed.
Mar 4, 2019
I realized that this won't allow us to know when is the last time a dyndns domain tried to update itself. It shouldn't be a problem but this will close the possibility of automatically removed them (the tool old ones) if we try to do that one day.
I'm not expecting this to be a problem but we just have to keep that in mind.
Hm yea I was wondering about that the other day ... still there could be some brutal way of doing this like removing all domains that points to an IP that doesnt ping (or doesnt answer to http(s) on /yunohost/sso ...) And if those were "actual" instance the dyndns should kick in a few minutes after and refresh the IP