Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min version for all helpers #664

Merged
merged 3 commits into from Mar 21, 2019

Conversation

Projects
None yet
4 participants
@maniackcrudelis
Copy link
Contributor

commented Feb 25, 2019

The problem

When packaging, it can be difficult to evaluate the minimal version of YunoHost you should require.

Solution

Add the minimal version required for each helpers.
Unfortunately, it will be hard to maintain...

PR Status

Ready for reviews

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@maniackcrudelis maniackcrudelis referenced this pull request Feb 25, 2019

Merged

Testing #59

5 of 8 tasks complete
@Josue-T

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

It will quite difficult but I think that it's also important to know the change. By example for the nginx helper, we added the argument to pass some other variable to change. I think that this information is as important as the version when the helper was interoduced. For getops too.

Maybe we can write the required version since the last change...

@alexAubin
Copy link
Member

left a comment

LGTM, sounds like a benign change

@alexAubin

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Maybe we can write the required version since the last change...

Sooo do we implement this or merge as is ? Personally I'd say if those non-backward compatible changes are from before 3.0 we can ignore it :/

@alexAubin alexAubin added this to the 3.5.x milestone Mar 7, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

It's more changes after the version 3.
But I think it's already going to be hard to maintain those version numbers...

@alexAubin

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Sooo uuuh, to merge or not to merge, that is the wondering ̣¿:o|

maniackcrudelis added some commits Mar 18, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

Let's merge in 3 days ;)

@maniackcrudelis maniackcrudelis merged commit 3f0632f into stretch-unstable Mar 21, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@maniackcrudelis maniackcrudelis deleted the helpers_min_version branch Mar 21, 2019

@yalh76

This comment has been minimized.

Copy link
Contributor

commented on data/helpers.d/psql in e8da94d Apr 12, 2019

Just to let you know:
Arguments for ynh_psql_remove_db have inverted in legacy mode since previous version.
For apps not having the same db_user and db_name, this will cause issues during app removal and package_check errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.