Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] adding a new test in case the info.json file exists but not the tar and vice versa #667

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@christalib
Copy link

commented Feb 26, 2019

The problem

this issue

Solution

Adding one more test but it isn't the best one

PR Status

...

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Uh in fact I think that's not the real issue. It turns out that YunoHost is supposed to be able to work even if there's no .info.json file directly associated with the archive - because this file is actually also in the archive itself. This is what is handled here : https://github.com/YunoHost/yunohost/blob/stretch-unstable/src/yunohost/backup.py#L2213

I think the original issue lies in here : https://github.com/YunoHost/yunohost/blob/stretch-unstable/src/yunohost/backup.py#L2158-L2171

The original issue is in fact not trivial to reproduce but I think @e-lie somehow renamed an archive while keeping the .tar.gz in the name. So you can reproduce the issue like this :

  • creating a new backup using yunohost backup create
  • going to /home/yunohost.backup/archives
  • Rename the archive like this mv your_archive.tar.gz your_archive.tar.gz.bkp (it's important to keep .tar.gz in the archive name somewhere ;))
  • Run yunohost backup list
  • If it's still not clear what's happening, try to touch foo.tar.gz.yolo.bar and you should see it's trying to look for a foo.tar.gz archive because of that f.rindex('.tar.gz') :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.