Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] allow 'display_text' ~fake~ argument in manifest.json #669

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
5 participants
@Psycojoker
Copy link
Member

commented Mar 4, 2019

The problem

A very simple idea I had since quite some time: allow to add a way in the argument list of an app to have an argument that simply display text and fetch no value as way to allow app packagers to display information for the user.

The usage is very simple, simply had this kind of argument in your manifest:

            {
                "name": "some_text",
                "type": "display_text",
                "text": "This is some text that is going to be displayed.\n\nAnother line."
            },

PR Status

Working. Need the equivalent for the admin UI once it's agreed on principle.

How to test

Create an empty app and had this kind of argument to the manifest and had an empty shell script and run the installation.

Example:

2019-03-04-031132_714x243_escrotum

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@Psycojoker Psycojoker added this to the 3.x milestone Mar 4, 2019

@alexAubin
Copy link
Member

left a comment

LGTM 😋

Out of curiosity, what's the difference between print and sys.stdout.write ?

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

Out of curiosity, what's the difference between print and sys.stdout.write ?

I had the feeling that sys.stdout.write would interpret the "\n" (and not "print") but now thinking back about it I'm not sure it's actually needed... my brain probably farted ^^'

@Psycojoker Psycojoker force-pushed the manifest_texte_argument branch from 97a3fde to b8c5e9f Mar 4, 2019

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

My brain did farted, I've removed it x)

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

Ping @YunoHost/apps for principle approval/review.

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

That's probably going to be useful!

@JimboJoe
Copy link
Member

left a comment

LGTM, nice idea! 👍

@kay0u

kay0u approved these changes Mar 4, 2019

Copy link
Contributor

left a comment

Nice feature!

@alexAubin

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Yolomergin'

@alexAubin alexAubin merged commit a066230 into stretch-unstable Mar 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the manifest_texte_argument branch Mar 7, 2019

@alexAubin alexAubin modified the milestones: 3.x, 3.5.x Mar 7, 2019

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

To be confirmed but we probably need to related PR for the webadmin before the release '^'

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

I can do that tomorrow I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.