Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[enh] Check that required services are up before running app install and upgrade #670
see this kind of situation : https://forum.yunohost.org/t/nextcloud-erreur-502-et-mise-a-jour-impossible-apres-migration-yunohost-3-4-2-4/7204/11 - an app upgrade miserably failed trying to reload php7.0-fpm which was most probably down before the whole action even started and this could be avoided.
Add a check that some services are up before running app install or app upgrades, according to the info given in the manifest. Unfortunately the manifest does not seem to be available during restore (or it's just not loaded/used ?) so it's not straigtforward to also add it here
Tested for app install
How to test
E.g. stop php7.0-fpm and try installing wordpress
So meh ... I dunno what to do with this ... the idea was mostly that I saw a few times happening that nginx or php was down before trying to install an app or upgrade one, and it miserably failed ...
We can try to generalize to all services but meh I really mainly care about php-fpm and mysql because those are the ones "likely" to be broken :|