Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Backup fails because output directory not empty #672

Merged
merged 4 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@alexAubin
Copy link
Member

commented Mar 7, 2019

The problem

c.f. YunoHost/issues#1308 which sometime breaks upgrade for silly reasons

Solution

Implement the 'FIXME' by attempting to unmount / clean the directory.

While fixing this, I realized that the function _recursive_umount probably had a buggy behavior / return value ... Dunno if that explains why the original issue happened in the first place, but could be related.

PR Status

Tested and works okay

How to test

# Initialize dummy file
mkdir /var/toto
echo "toto" > /var/toto/toto

# Initialize dummy tmp directory
cd /home/yunohost.backup/tmp
mkdir yoloswag; cd yoloswag

# Mount dummy stuff in the tmp directory
mkdir toto
mount -o ro,bind /var/toto ./toto

# Try to create a backup
cd
yunohost backup create -n yoloswag --debug

Should see in the debug output (at the beginning) that it complains the directory ain't empty and attempts to clean it

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.5.x milestone Mar 7, 2019

@alexAubin alexAubin requested a review from zamentur Mar 7, 2019

@zamentur
Copy link
Contributor

left a comment

LGTM, untested

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

Yolomergin'

@alexAubin alexAubin merged commit 5790ad4 into stretch-unstable Mar 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix-1308-output-directory-not-empty branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.