Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup tests #673

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
1 participant
@alexAubin
Copy link
Member

commented Mar 8, 2019

The problem

Backup tests failed for two different reason ...

  • a weird edge case about link creation during the backup ... files were actually on different device but there seem to be no way to detect this ... I suspect this is because of running on a weird LXC setup with encrypted hard drive inside some /dev/mapper stuff such that the real "logical" (?) devices are hidden ...
  • some changes in the pytest version or idk, such that the way to access function / tests markers broke

Solution

Fix those

PR Status

Tested on my machine

How to test

Run the backup/restore tests

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.5.x milestone Mar 8, 2019

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

Planning to merge soon because that's mainly technical stuff that is only likely to affect people running tests...

@alexAubin alexAubin merged commit f221024 into stretch-unstable Mar 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix-backup-tests branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.