Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Support php versions in ynh_add_fpm_config #674

Merged
merged 2 commits into from Mar 28, 2019

Conversation

Projects
None yet
3 participants
@maniackcrudelis
Copy link
Contributor

commented Mar 8, 2019

The problem

ynh_add_fpm_config can't create a fpm config for another version than 7.0

Solution

Allow to specify the version of php to use.

PR Status

Ready to be reviewed.

How to test

https://github.com/YunoHost-Apps/phpinfo_ynh

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

@kay0u

kay0u approved these changes Mar 8, 2019

Copy link
Contributor

left a comment

Looks good

@alexAubin
Copy link
Member

left a comment

Not tested but LGTM 👍

@alexAubin alexAubin added this to the 3.5.x milestone Mar 24, 2019

@alexAubin alexAubin merged commit f5f2a18 into stretch-unstable Mar 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the php_versions branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.