Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ynh_app_setting_get and ynh_app_setting_delete don't have a fou… #676

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

commented Mar 10, 2019

The problem

ynh_app_setting_get and ynh_app_setting_delete don't have a fourth argument.
/usr/share/yunohost/helpers.d/setting: line 63: $4: unbound variable

Solution

Init $4 with a blank value if unset.

PR Status

...

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Mergin' as microdecision ;D Sorry about that, thanks for the fix

@alexAubin alexAubin merged commit 2c9d1b4 into stretch-unstable Mar 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix_ynh_app_setting branch Mar 10, 2019

@alexAubin alexAubin added this to the 3.5.x milestone Mar 10, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

No problem.
That's why it's wonderful to have an unstable CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.