Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix the dbus interface to get info for services #698

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
2 participants
@alexAubin
Copy link
Member

commented Apr 2, 2019

The problem

c.f. YunoHost/issues#1316

Solution

Very intuitive™, one should use LoadUnit and not GetUnit ...

PR Status

Tested and working ... though still need to check that this doesnt break webadmin

How to test

Try to run yunohost service status with a disabled service. Also you can try to add in /etc/yunohost/services.yml a service that doesn't exist at all

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
[fix] Fix the dbus interface to get info for services, because this w…
…as not working when service is disabled

@alexAubin alexAubin added this to the 3.5.x milestone Apr 2, 2019

@alexAubin alexAubin merged commit 99bd378 into stretch-unstable Apr 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix-service-info-for-disabled-services branch Apr 2, 2019

@Psycojoker

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Sometime I really have the feeling that the world is splited between people that want to make things intuitive and the dbus developpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.