Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] WebSocket proxying #701

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@kay0u
Copy link
Contributor

commented Apr 4, 2019

The problem

Unable to use these lines in nginx conf:

	proxy_set_header Upgrade $http_upgrade;
	proxy_set_header Connection $connection_upgrade;

for WebSocket proxying.

I'm not an expert in Nginx but you can find doc here:
http://nginx.org/en/docs/http/websocket.html

Solution

What I've done inside the file server.tpl.conf

PR Status

...

How to test

Add these lines in nginx conf of an app that use websocket

   proxy_set_header Upgrade $http_upgrade;
   proxy_set_header Connection $connection_upgrade;

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

kay0u added some commits Apr 4, 2019

@alexAubin
Copy link
Member

left a comment

Uhokay, not sure what this corresponds to and it feels weird to have to put this outside the server block, but why not ô.o

@alexAubin alexAubin added this to the 3.6.x milestone Apr 12, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Was wondering if multidomain would cause issue, but apparently it doesn't ô.o

Planning to merge in a few days

@alexAubin alexAubin merged commit 9b3c970 into YunoHost:stretch-unstable Apr 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kay0u kay0u deleted the kay0u:patch-5 branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.