Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support in restore script of ynh_setup_source #703

Merged
merged 3 commits into from Apr 22, 2019

Conversation

Projects
None yet
4 participants
@Josue-T
Copy link
Contributor

commented Apr 7, 2019

The problem

Actually the path to the app.src file in the helper ynh_setup_source work only in install and upgrade script.

Solution

Add the support for restore script by adding a specific path if the general path is not available.

PR Status

Tested work on monitorix.

How to test

Use the helper in a restore script of an app.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
Add support in restore script of ynh_setup_source
Actually the path to the app.src file in the helper ynh_setup_source work only in install and upgrade script.
Add the support for restore script.

@Josue-T Josue-T requested review from JimboJoe and maniackcrudelis Apr 7, 2019

maniackcrudelis added some commits Apr 9, 2019

@alexAubin alexAubin added this to the 3.6.x milestone Apr 12, 2019

@alexAubin
Copy link
Member

left a comment

LGTM

@zamentur
Copy link
Contributor

left a comment

LGTM

@alexAubin

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Merging right now because it's 15 days old with 3 approvals

@alexAubin alexAubin merged commit 9615045 into stretch-unstable Apr 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the ynh_setup_source-restore_support branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.