Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix extraction of weight value for ynh_script_progression #710

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

commented Apr 13, 2019

The problem

The weight value will take everything after --weight=, especially --time or --last

Solution

Fix the regex

PR Status

Ready to be reviewed.

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

@alexAubin alexAubin added this to the 3.6.x milestone Apr 16, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Yolomerging because that looks like a small benign change ?

@alexAubin alexAubin merged commit d2e01a4 into stretch-unstable Apr 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix_ynh_script_progression branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.