Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix extraction of weight value for ynh_script_progression #710

Merged
merged 2 commits into from Apr 16, 2019
Merged

[fix] Fix extraction of weight value for ynh_script_progression #710

merged 2 commits into from Apr 16, 2019

Conversation

maniackcrudelis
Copy link
Contributor

The problem

The weight value will take everything after --weight=, especially --time or --last

Solution

Fix the regex

PR Status

Ready to be reviewed.

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

@alexAubin alexAubin added this to the 3.6.x milestone Apr 16, 2019
@alexAubin
Copy link
Member

Yolomerging because that looks like a small benign change ?

@alexAubin alexAubin merged commit d2e01a4 into stretch-unstable Apr 16, 2019
@alexAubin alexAubin deleted the fix_ynh_script_progression branch April 16, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app helpers
Projects
None yet
Milestone
3.6.x
2 participants
@maniackcrudelis @alexAubin