Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use printers in helpers #712

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

commented Apr 13, 2019

The problem

Use printers instead of echo in helpers.

Solution

...

PR Status

...

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

@alexAubin
Copy link
Member

left a comment

LGTM

@alexAubin alexAubin added this to the 3.6.x milestone Apr 16, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Planning to merge in a few days

@alexAubin alexAubin merged commit fdcf934 into stretch-unstable Apr 25, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the use_printers branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.