Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Add the current work to the progression bar #715

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

commented Apr 17, 2019

The problem

I'd like to find a way to announce a long step during an app script, without having to say for all steps (it's going to be long !)
Also, watching the progression bar filling up, I thought it was too bad to know only after the job's done that it was actually a quick or a long step.

Solution

Split the progression bar in 3 parts, work done, ongoing work, work not yet done.
A example with leed (which was my testing app).

Info: [+...................] > Validating installation parameters...
Info: [#+..................] > Storing installation settings...
Info: [##..................] > Creating a MySQL database...
Info: [##++................] > Setting up source files...
Info: [####+...............] > Configuring nginx web server...
Info: [#####+..............] > Configuring system user...
Info: [######+.............] > Configuring php-fpm...
Info: [#######+++..........] > Installing Leed with Curl...
Info: [##########+.........] > Setting up a cron file...
Info: [###########+++++....] > Configuring fail2ban...
Info: [################+...] > Configuring SSOwat...
Info: [#################+..] > Reloading nginx web server...
Info: [####################] > Installation of leed completed

PR Status

Ready to be reviewed.
Tested with success on leed.

How to test

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

maniackcrudelis added some commits Apr 17, 2019

@alexAubin
Copy link
Member

left a comment

Quite lazy to read the code, but looks like a really nice improvement 👍

@alexAubin alexAubin added this to the 3.6.x milestone Apr 18, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Planning to merge in a few days

@alexAubin alexAubin merged commit c55afa4 into stretch-unstable Apr 25, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the expected_progression branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.