Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers for sso config #720

Merged
merged 2 commits into from May 21, 2019

Conversation

Projects
None yet
3 participants
@maniackcrudelis
Copy link
Contributor

commented May 6, 2019

The problem

We have lost the documentation about sso config keys

Solution

Add helpers to add directly such config keys.
And bring documentation back with those helpers.

PR Status

Ready to be reviewed.

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

Add helpers for sso config
And especially restore the old documentation about those keys
@alexAubin
Copy link
Member

left a comment

Not tested but blindly trusting it ... Any feedback from the @YunoHost/apps group maybe ?

@alexAubin alexAubin added this to the 3.6.x milestone May 17, 2019

@kay0u

kay0u approved these changes May 17, 2019

Copy link
Contributor

left a comment

LGTM

# An URL set with 'skipped_uris' key will be totally ignored by the SSO,
# which means that the access will be public and the logged-in user information will not be passed to the app.
#
# Requires YunoHost version ?.?.? or higher.

This comment has been minimized.

Copy link
@kay0u

kay0u May 17, 2019

Contributor

Will be merged in 3.6.0, so change "?"

This comment has been minimized.

Copy link
@maniackcrudelis

maniackcrudelis May 17, 2019

Author Contributor

Are you sure it's going to be ?
This should be done during the testing release.

And could be done already for the previous release.

This comment has been minimized.

Copy link
@kay0u

kay0u May 17, 2019

Contributor

@alexAubin add it to the milestone 3.6.x (but this comment is more a reminder for him)

I can't find these helpers O.o

# An URL set with unprotected_uris key will be accessible publicly, but if an user is logged in,
# his information will be accessible (through HTTP headers) to the app.
#
# Requires YunoHost version ?.?.? or higher.

This comment has been minimized.

Copy link
@kay0u

kay0u May 17, 2019

Contributor

Same here

#
# An URL set with protected_uris will be blocked by the SSO and accessible only to authenticated and authorized users.
#
# Requires YunoHost version ?.?.? or higher.

This comment has been minimized.

Copy link
@kay0u

kay0u May 17, 2019

Contributor

And here

@alexAubin alexAubin merged commit 81c7d12 into stretch-unstable May 21, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@alexAubin alexAubin deleted the helpers_sso_settings branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.