Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ynh_script_progression #723

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
2 participants
@alexAubin
Copy link
Member

commented May 15, 2019

The problem

ynh_script_progression is awesome but I noticed that app logs are filled with hundreds of lines related to the computation of the progress bar. But some parts of it could be factorized to be only done once so that'll slightly simplify the debug logs

Solution

Compute the stuff we can only once using "global"(?) variables

PR Status

Tested and seems to be working, but I'm not an expert of this helper ;)

How to test

Run an app install and check the detailed log

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

Too lazy to test, but read carefully the diff, looks ok.
Let's the CI told us if it's ok ;)

@alexAubin alexAubin added this to the 3.6.x milestone May 18, 2019

@alexAubin alexAubin merged commit f14d5c4 into stretch-unstable May 21, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the optimize-script-progression branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.