Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Stupid issue with files inside tar : foo is not the same as ./foo #726

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
1 participant
@alexAubin
Copy link
Member

commented May 18, 2019

The problem

https://forum.yunohost.org/t/restore-from-folder-rather-then-tar-gz/7885
https://cybre.space/@aleks/102117385695119433
https://serverfault.com/questions/457480/tar-leading-period-slash

Solution

Check for both info.json and ./info.json ... and similarly each time we try to extract a file.

PR Status

Tested on my side and working

How to test

You can reproduce the issue by untaring an archive and retaring it with :

cd thearchive/
tar -zcvf ../buggyarchive.tar.gz ./

Then using yunohost backup info buggyarchive or trying to restore it.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin changed the title [fix] Stupid issue with files inside tar : foo is not the same as ./f… [fix] Stupid issue with files inside tar : foo is not the same as ./foo May 18, 2019

@alexAubin alexAubin added this to the 3.6.x milestone May 22, 2019

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

Sooo proposing to merge soon

@alexAubin alexAubin merged commit 5d88301 into stretch-unstable Jun 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the stupid-tar-leading-dot-issue branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.