Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use manifest.json/actions.json args format for the config_panel.toml #734

Merged
merged 6 commits into from Jul 2, 2019

Conversation

Projects
None yet
2 participants
@Psycojoker
Copy link
Member

commented Jun 4, 2019

The problem

WIP work on this weekend, it depends on the #732 toml PR.

THIS REQUIRES A LITTLE BIT OF CHANGES FOR THE FORMAT OF THE CONFIG PANEL since now it's the manifest/actions format that is used.

The modifications are to this format in the [options] section, so, from head:

  • bool -> boolean
  • name -> ask

Here is a working (format) config https://gist.github.com/Psycojoker/c9ea335e596c4684b042812b7b0804c3

Solution

...

PR Status

...

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
Show resolved Hide resolved src/yunohost/app.py Outdated

@Psycojoker Psycojoker removed the work needed label Jun 29, 2019

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

Okay, that should be good, I've tested most of the things and that works for me ™

As a reference here is the script (and modify all the time) and config_panel I've used to test this feature. It's lazy as feuk but does its purpose https://gist.github.com/Psycojoker/c9ea335e596c4684b042812b7b0804c3

@maniackcrudelis you can test it now if you want :)

I think that's all on the todo list before moving out of experimental? I'm not 100% sure but we probably start advertising it to apps dev if everything is fine and gather feedback once we feel ready.

I need to add the .toml format to the actions and the manifest too I think.

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

Ah yeah, another important part is: how the hell are we going to do the CLI interface? (except if we spawn ncurse but that looks a bit overkill here) (while I really would love to put an urwid interface in yunohost that sucks for scripting)

@alexAubin alexAubin merged commit 9b3a523 into stretch-unstable Jul 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the config_panel_ynh_args branch Jul 2, 2019

@alexAubin alexAubin added this to the 3.6.x milestone Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.