Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod] Proper return interface for app config #739

Merged
merged 3 commits into from Jul 2, 2019

Conversation

Projects
None yet
1 participant
@alexAubin
Copy link
Member

commented Jun 18, 2019

The problem

That's a pretty technical thing, but the interface between apps and the core for config panel was a bit hackish due to the lack of easy way to transmit data from the app script to the core.

Solution

#526 introduced a new $YNH_STDRETURN pipe (?) which can then be parsed for json. This PR adds a new data type "plain_dict" which is more suited for the usecase of app config scripts and removes the need for the hackish solution 馃槈

PR Status

Tested and working on my machine

How to test

I tested it using leed, replacing the echo YNH_CONFIG_MAIN_IS_PUBLIC_IS_PUBLIC=false with ynh_return YNH_CONFIG_MAIN_IS_PUBLIC_IS_PUBLIC=false (ynh_return being a new helper which simply echoes stuff in $YNH_STDRETURN)

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin merged commit 8917238 into stretch-unstable Jul 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the proper-return-interface-for-app-config branch Jul 2, 2019

@alexAubin alexAubin added this to the 3.6.x milestone Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.