Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong usage of ynh_mysql_user_exists #743

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@alexAubin
Copy link
Member

commented Jun 28, 2019

The problem

ynh_mysql_user_exists returns 1 or 0 as error code ... but is used with if $(ynh_mysql_user_exists) instead of if ynh_mysql_user_exists ... Dunno if that's really troublesome since apparently that never caused any issue, but at least that's unconsistent and confusing ...

Solution

Fix it eh

PR Status

Done, but untested :/

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.6.x milestone Jun 28, 2019

@alexAubin alexAubin modified the milestones: 3.6.x, 3.7.x Jul 5, 2019

@JimboJoe
Copy link
Member

left a comment

LGTM 👍

@zamentur
Copy link
Contributor

left a comment

LGTM

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

It should be tested...
And ynh_mysql_user_exists should be rewritten correctly, the result of the condition is unclear.
https://github.com/YunoHost/yunohost/blob/fix-wrong-usage-of-mysql-user-exists/data/helpers.d/mysql#L161

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

So uh what's up with this .. I tested it on my machine and it works as expected (both ynh_mysql_execute_as_root and ynh_mysql_user_exists)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.