Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] allows actions.toml #744

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
3 participants
@Psycojoker
Copy link
Member

commented Jun 30, 2019

The problem

json is boring to write and we've discovered toml as a better replacement for humans so after doing this for config panel, allow this for actions.

Manifest is next to come.

ALTOUGH.

There is a problem charly.

Debian being debian, python-toml is version 0.9 here, this mean that this kind of super handy shorthand isn't parsed with the version 0.9 (but is with the version 0.10 which is available on pypi):

description.en = "le anglish"
description.fr = "the frounce"

And there is not python-toml version 0.10 in testing or unstable.

This is really annoying.

Ideally I guess we need to ship it ourselves but I really wasn't expecting this additional work.

We can still write things like although:

[description]
en = "le anglish"
fr = "the frounce"

But in subcategories it's a bit annoying:

[this_is_an_actions.arguments.argument_one]
    name = "plop" # stuff needs to be before there
    [this_is_an_actions.arguments.argument_one.ask]
    en = "le anglish"
    fr = "the frounce"

PR Status

Tested and working, python tells me that json and toml versions are identic.

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin merged commit e987ae5 into stretch-unstable Jul 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin added this to the 3.6.x milestone Jul 2, 2019

@alexAubin alexAubin deleted the actions-dot-toml branch Jul 2, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

@Psycojoker, I don't know how I'm suppose to build the toml format for an action, do you have an implementation example ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.