Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] moulinette logs were never displayed #lol #758

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@Psycojoker
Copy link
Member

commented Jul 20, 2019

Needed for YunoHost/moulinette#205

For some reason logs from core of the moulinette were never displayed at all since 4 years 馃し鈥嶁檪

@decentral1se
Copy link
Contributor

left a comment

Ah, good catch then, finally ;)

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2019

Will merge in next days of no oppositions.

@alexAubin

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

Agreed on the principle but :

  • you might want to do the same thing on yunohost-api for consistency ?
  • we might want to move the info message popping up every time you run a command about running action foo_bar with args {"arg1":...} to a debug level (and there are some other stuffs in Moulinette that we might want to consider moving to debug level)
@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2019

you might want to do the same thing on yunohost-api for consistency ?

I'm not sure, this is really a different context but maybe? Don't know how adapted it is here :x (I don't use the admin that much)

* we might want to move the info message popping up every time you run a command about `running action foo_bar with args {"arg1":...}` to a debug level (and there are some other stuffs in Moulinette that we might want to consider moving to debug level)

Yup, make total sens, there is probably some cleaning to do.

@alexAubin

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

I'm not sure, this is really a different context but maybe? Don't know how adapted it is here :x (I don't use the admin that much)

Well eh, just that if the goal is to warn the user after lock taking a long time to acquire, you also want to have the warning being displayed in the webadmin and not just when using the cli :s

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

I'm not sure, this is really a different context but maybe? Don't know how adapted it is here :x (I don't use the admin that much)

Well eh, just that if the goal is to warn the user after lock taking a long time to acquire, you also want to have the warning being displayed in the webadmin and not just when using the cli :s

Ah yes, indeed! I need to check how it works in the admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.