Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apache2 as conflicting package #760

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@alexAubin
Copy link
Member

commented Jul 20, 2019

The problem

In various situation, we end up with people voluntarily installing apache2, or various dependency stuff in apt/dpkg ending up willing to install apache2 because some packages have it as recommended or whatever ...

This ends up breaking instances because once the server restarts, apache may start before nginx

Solution

Add apache2 as a damn conflict to end this madness. YunoHost is a packaged flagged as "Essential" in Debian control file, so YunoHost should win in a fight against apache2 (or at least, even trying to install apache2 explicitly manually will result in a "Are you really sure?" question from apt)

PR Status

Yolocommited, not really tested but meh

How to test

Well eh find a way to properly update the control file of an existing install and try to install apache2...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin changed the title Add apache2 as conflicting dependency Add apache2 as conflicting package Jul 20, 2019

@Psycojoker

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

I sadly know valid situations where people will change apache2 port and put it behind nginx so I'm not sure we can do that :s (which is a shame because preventing apache2 from being used is really a good idea for a lot of situations of uninformed users)

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

Hmokay so agreed that this PR is not the right way to go ...

Alternatively : we can try to add small config stuff to prevent apache2 from being installed ... for example that kind of thing is already done to try to prevent networkmanager from being installed on ARM boards (because it completely messes up the whole /etc/resolv.conf) :

https://github.com/YunoHost/arm-images/blob/master/userpatches/customize-image.sh#L23-L30

If we put this, apache2 shouldn't be inadvertendly installed ... but I think a user could still manage to install it (well in the worst case, only need to remove this piece of config in /etc/apt/preferences)

@Psycojoker

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

That would solve this problem on installation of YunoHost, right? I though to PR was for a running YunoHost

Or do you mean this part? https://github.com/YunoHost/arm-images/blob/master/userpatches/customize-image.sh#L26-L30

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2019

What I have in mind is adding some stuff to the regen-conf mechanism somehow to add pieces of config similar to this in the appropriate file, so that would work both for existing instances and new instances

Still a random thought though, would need to actually test it to validate that it'd work and make sense

@Psycojoker

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Ok, LGTM as a potential solution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.