Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop on failed app upgrade #769

Open
wants to merge 7 commits into
base: stretch-unstable
from

Conversation

@Psycojoker
Copy link
Member

commented Aug 7, 2019

The problem

app_upgrade will try to upgrade all apps it receives, even if one upgrade fails. It turns out that in practice one app failed upgrade could break everything and make other app upgrades fail.

Solution

Stop if the upgrade of one application failed.

PR Status

Untested.

How to test

I guess you need a list of fake apps to do that?

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@decentral1se
Copy link
Contributor

left a comment

Some spelling nitpicks, LGTM. Didn't manually test.

src/yunohost/app.py Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved

Psycojoker and others added some commits Aug 7, 2019

[mod] typo
Co-Authored-By: decentral1se <lukewm@riseup.net>
[mod] typo
Co-Authored-By: decentral1se <lukewm@riseup.net>
[mod] typo
Co-Authored-By: decentral1se <lukewm@riseup.net>
@alexAubin
Copy link
Member

left a comment

Looks okay to me

src/yunohost/app.py Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved

Psycojoker and others added some commits Aug 18, 2019

[mod] typo
Co-Authored-By: Alexandre Aubin <alex.aubin@mailoo.org>
[mod] typo
Co-Authored-By: Alexandre Aubin <alex.aubin@mailoo.org>
@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

Has anyone tested this one 😅?

@alexAubin

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

I didn't but i can ¯\_(ツ)_/¯

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

If that's not too hard for you that would be great :x (I'm not 100% confident about this code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.