Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod] more permissive email regex #770

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@Psycojoker
Copy link
Member

commented Aug 11, 2019

The problem

Email regex is way too restrictive, doesn't allow "+" stuff etc...

Extracted from
https://github.com/YunoHost/yunohost/pull/176/files#diff-85bc3950f9df27a6e9d05ea5ff3c82fbR129
by Julien Malik

Solution

Make simpler stuff, email for regex is fucked up after all, we can only assume to have a "@" somewhere.

PR Status

Not tested but looks fine.

We probably need to check if this doesn't allow ldap query injection

How to test

Create a new user with a fucked up email address.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@zamentur

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

In this precise case, we don't want an email with "+" ...
We discuss yesterday to remove this email question adn replace it by just asking for a domain, to avoid some user difficulties during thunderbird configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.