Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Display other system logs #777

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[enh] Display other system logs #777

wants to merge 1 commit into from

Conversation

@zamentur
Copy link
Contributor

@zamentur zamentur commented Aug 15, 2019

The problem

Some system log are not available in web admin

Solution

This PR add this log in Tools > Log like it was designed during the Log PR.
system_logs

PR Status

Ready
This PR depends of an other on yunohost-admin YunoHost/yunohost-admin#255

How to test

We need to merge this in unstable to test completely, but you can test like this:

  • Pull branch on yunohost and yunohost-admin
  • use git on yunohost and yunohost-admin
  • cp -R yunohost/data/other/logs/* /var/log/yunohost/categories/
  • service yunohost-admin
  • Try to use the webadmin to see the new log in screenshot

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
Copy link
Member

@alexAubin alexAubin left a comment

Could we also have other logs that are regularly relevant such as :

  • /var/log/daemon.log, typically the right place to look into half of the time when a service fails to start
  • maybe /var/log/debug but I'm not sure about what it really contains
  • /var/log/mail.* ?

Loading

@@ -0,0 +1 @@
log_path: /var/log/alternatives.log
Copy link
Member

@alexAubin alexAubin Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh wokay ... I'm not sure that this file really is any useful ? Can you elaborate on what kind of insight it provides ?

Loading

Copy link
Contributor Author

@zamentur zamentur Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be usefull in some situation with malicious programs running as default programs.
Maybe also to debug some php version conflict see https://github.com/YunoHost-Apps/framaforms_ynh/blob/testing/scripts/install#L191 .

Loading

@@ -0,0 +1 @@
log_path: /var/log/dpkg.log
Copy link
Member

@alexAubin alexAubin Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as alternatives.log, I'm not sure what we're expecting to find in this file 😕

Loading

Copy link
Contributor Author

@zamentur zamentur Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dpkg provide all manually dpkg packages installed, it could be usefull with some apps installing manually some dpkg.

Loading

@@ -0,0 +1 @@
log_path: /var/log/apt/history.log
Copy link
Member

@alexAubin alexAubin Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add also term.log which is really the actual log of apt operations ?

Loading

Copy link
Contributor Author

@zamentur zamentur Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

Loading

@@ -0,0 +1 @@
log_path: /var/log/kern.log
Copy link
Member

@alexAubin alexAubin Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like kern.log is just a subset of messages so I would choose one or the other (messages.yml apriori)

Loading

"log_kernel": "Information and events about the linux kernel",
"log_messages": "General system activities",
"log_root_bash_history": "History of commands ran by root",
"log_wtmp": "Login and logout history",
Copy link
Member

@alexAubin alexAubin Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there's no wtmp configured...?

Loading

Copy link
Contributor Author

@zamentur zamentur Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep i removed it because this file make a big 500 error in moulinette and is not so much relevant

Loading

"log_admin_bash_history": "History of commands ran by admin",
"log_alternatives": "Change to default programs",
"log_auth": "Connection history",
"log_btmp": "Failed login attempts",
Copy link
Member

@alexAubin alexAubin Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there's no btmp configured...?

Loading

"log_btmp": "Failed login attempts",
"log_dpkg": "History of installed debian packages",
"log_fail2ban": "Banning history",
"log_history": "History of installed debian packages with apt",
Copy link
Member

@alexAubin alexAubin Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well uh, is this for apt, or is this the category for the admin/root history ..? Shouldn't this be log_package ..?

Also I would really rename the package category to apt_and_dpkg or just apt or system_packages to make a clear distinction to apps or other packages

Loading

@alexAubin alexAubin added this to the 3.8.x milestone Sep 1, 2019
@zamentur
Copy link
Contributor Author

@zamentur zamentur commented Sep 16, 2019

About this PR. We discuss it and Aleks think it should be transform into conf files store into /etc/yunohost . So it make it quite more difficult to implement.

Loading

@zamentur zamentur changed the base branch from stretch-unstable to dev Sep 23, 2020
@zamentur zamentur added this to the Horizon milestone Jan 3, 2021
@zamentur zamentur added this to 5.x or more in Pending Jan 4, 2021
@zamentur zamentur removed this from the Horizon milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pending
5.x or later / no energy / low priority
2 participants