Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate change on LDAP conf / authenticator #784

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@alexAubin
Copy link
Member

commented Aug 23, 2019

The problem

c.f. changes in YunoHost/moulinette#216

Solution

Propagate the change, use a simple dict instead of a bunch of tuples

PR Status

Tested and working if you have the right moulinette PR checked out

How to test

Try to launch yunohost tools shell and check that the ldap object if working properly

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@decentral1se
Copy link
Member

left a comment

LGTM

"name": "as-root",
"parameters": { 'uri': 'ldapi://%2Fvar%2Frun%2Fslapd%2Fldapi',
'base_dn': 'dc=yunohost,dc=org',
'user_rdn': 'gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth' },

This comment has been minimized.

Copy link
@decentral1se

decentral1se Aug 24, 2019

Member
Suggested change
'user_rdn': 'gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth' },
'user_rdn': 'gidNumber=0,uidNumber=0,cn=peercred,cn=external,cn=auth' },

I know it's the same as the original text but just checking - the + is not a typo, right!?

This comment has been minimized.

Copy link
@alexAubin

alexAubin Aug 24, 2019

Author Member

Eeeeh no idea :s (@Josue-T do you know about this ?)

This comment has been minimized.

Copy link
@Josue-T

Josue-T Aug 24, 2019

Contributor

Well, + is not same than ,. , is the separation between each element of the LDAP tree. For + it's different, it's really specific, it's liked to the root authentication. Don't really know exactly what it mean but probably something like gidNumber=0 and uidNumber=0. Anyway + true.

@Psycojoker
Copy link
Member

left a comment

LGTM (but I don't know much about it)

@alexAubin alexAubin added this to the 3.8.x milestone Sep 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.