Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that exist before the calculate the checksum #792

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@Josue-T
Copy link
Contributor

commented Sep 7, 2019

The problem

If we try to use the helper ynh_add_fail2ban_config in the restore script we have a problem with the helper ynh_backup_if_checksum_is_different because we have the checksum in the settings but the file is not installed.

Solution

Check that the file exist before to calculate the checksum

PR Status

Tested and it work

How to test

  • Checkout the branch.
  • Try to use the helper ynh_add_fail2ban_config in a restore script

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@Josue-T Josue-T requested review from alexAubin and zamentur Sep 7, 2019

@decentral1se
Copy link
Member

left a comment

Not manually tested but makes sense 👍

@alexAubin alexAubin added this to the 3.7.x milestone Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.