Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Stale / undefined i18n strings #793

Open
wants to merge 2 commits into
base: stretch-unstable
from

Conversation

@alexAubin
Copy link
Member

commented Sep 10, 2019

The problem

There are many unused i18n strings which creates artificial work for translators ...

Also, some strings which are used in the code are not defined anywhere.

Solution

I use this small old script in tests/_test_m18nkeys.py to parse the code in a very dirty way to identify what strings are used inside m18n.n and YunohostError

I fixed a few things, but in the these strings are still not defined :

   - apps_already_up_to_date
   - bind_mouting_disable
   - error_reading_file
   - operation_interrupted
   - permission_update_failed_clear
   - permission_update_failed_populate
   - premission_update_failed

PR Status

Should implement / fix those missing strins somehow

How to test

Uh idk :[ I guess mostly the thing to test is the small refactor about testing the requirements

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@Psycojoker

This comment has been minimized.

Copy link
Member

commented on 05d28d6 Sep 10, 2019

I don't understand why this commit is in this PR :s

This comment has been minimized.

Copy link
Member Author

replied Sep 10, 2019

Hmyea sorry that was mostly because I wanted to get rid of the "package_not_installed" and "package_unexpected_error" strings and then I saw this code and was like "meh this is completely overengineered i want to get rid of this madness" T_T

This comment has been minimized.

Copy link
Member

replied Sep 10, 2019

Is it realistic to split this PR? That makes reviewing confusing :s (like I can totally accept the other commit but this one takes much more time to review/understand :x)

This comment has been minimized.

Copy link
Member Author

replied Sep 10, 2019

Yup I guess we can split it from the PR

This comment has been minimized.

Copy link
Member

replied Sep 10, 2019

Thx a lot ❤️

@Psycojoker

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

It's great to have done that, it was really a needed job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.