Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[fix] Use ID instead of name for generated_option #851
Using the "name" for each element in the config panel is bad because it could contains a space.
Use the ID.
Tested with synapse on this branch.
How to test
Install an app with a config panel. Try the config panel and check that each change is applied.
Looking at this I really don't understand how I could choose to use "name" instead of "id" when writing this code frankly...
Looking at this commit it's really weird that I've decided to change from it to name for variable generation... It's probably due to some shitty property of yunohost args format and was probably done for a good reason but 6 month later I have to admit that I really don't remember why :<
I need to dig into that.
Ok I got it, the short answer is: you are out of date with the recent modifications.
So except if we want to switch back to the old format, we don't want this modification so I'm closing this PR (re-open if needed :))