Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Refactor app_list and app_info, + add support for app categories #853

Merged
merged 5 commits into from Dec 12, 2019

Conversation

@alexAubin
Copy link
Member

alexAubin commented Nov 25, 2019

The problem

App categoriez bruh, we need them

Also app_list and app_info are complete madness so fuck these, refactored them. (The main point being the constant confusion between local info and info from the app catalog)

Solution

The app category thing can easily be introduced thanks to #778 . It is based on an evolution of the app list format, available here : https://app.yunohost.org/default/v2/apps.json (c.f. also the PR on the apps repo : YunoHost/apps#828 )

app_list and app_info got changed a lot :

  • app_info returns info about a single installed app. --full can be added to fetch all the info (useful for other part of the code + the admin). The info from the catalog is separated from the local info in an obvious way (there's a from_catalog entry)
  • app_list will now only list installed apps. Its code is pretty simple and just returns the app_info for all installed apps.
  • and then we have a new app_catalog meant to display ... the application catalog and that's it (not mixed with local info about locally installed apps, except maybe a flag saying if the app is already installed). It's also meant to expose the categories information.

PR Status

Still WIP, working on integration in the webadmin

How to test

Run yunohost app info, app list and app catalog

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin alexAubin added this to the 3.8.x milestone Nov 25, 2019
@alexAubin alexAubin mentioned this pull request Nov 25, 2019
@alexAubin alexAubin marked this pull request as ready for review Dec 2, 2019
@alexAubin alexAubin changed the title WIP: Refactor app_list and app_info, + add support for app categories [enh] Refactor app_list and app_info, + add support for app categories Dec 2, 2019
@cyxae

This comment has been minimized.

Copy link

cyxae commented Dec 9, 2019

It seems to be a good opportunity to refactor outdated "apps_overview" (https://yunohost.org/apps_overview) page of the documentation. Should I do that ?

@alexAubin

This comment has been minimized.

Copy link
Member Author

alexAubin commented Dec 12, 2019

@cyxae : ah yes indeed if you feel like it 👍

@alexAubin alexAubin merged commit 9f81d77 into stretch-unstable Dec 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@alexAubin alexAubin deleted the app-categories branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.