Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test and improve test stability #863

Open
wants to merge 5 commits into
base: stretch-unstable
from

Conversation

@Josue-T
Copy link
Contributor

Josue-T commented Dec 29, 2019

The problem

  • Some unit test fail (settings and app catalog)
  • It's sometime really complicated to pass all test because of bad DNS registry and dirty app cleanup

Solution

  • Fix the settings implementation
  • Fix the app catalog test
  • Improve the app cleanup after each tests
  • Force the DNS to make all request locally

PR Status

Now all test pass

Note that this PR also depends on YunoHost/moulinette#231 to fix everything.

How to test

Just launch the unit test (with ./ynh-dev test yunohost)

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
Josue-T added 3 commits Dec 29, 2019
@Josue-T Josue-T requested review from decentral1se, alexAubin and YunoHost/core-dev Dec 29, 2019
Josue-T added 2 commits Dec 29, 2019
@@ -60,6 +61,33 @@ def clean():
os.system("systemctl reset-failed nginx") # Reset failed quota for service to avoid running into start-limit rate ?
os.system("systemctl start nginx")

# Clean permission

This comment has been minimized.

Copy link
@kay0u

kay0u Jan 19, 2020

Member

I can't suggest in the right place but I think we should make sure that legacy_app__2 is removed too (multi instance tests):

line 41:

    if _is_installed("legacy_app__2"):
        app_remove("legacy_app__2")
@kay0u
kay0u approved these changes Jan 19, 2020
Copy link
Member

kay0u left a comment

Otherwise, LGTM, everything is green except the test_backup_binds_are_readonly test but I have no idea how to fix it.

(Needs this PR)

@kay0u kay0u added this to the 3.8.x milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.