Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adaptation for various actions #867

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@yalh76
Copy link
Contributor

yalh76 commented Jan 8, 2020

The problem

Logs speak about started even if the action was stop

Solution

using ${action}

PR Status

Done

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@kay0u
kay0u approved these changes Jan 9, 2020
Copy link
Member

kay0u left a comment

LGTM

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Jan 11, 2020

Clearly better.
Don't you think though that it would be even better with a correct verb, "stopped", "started", and so on ?

@yalh76

This comment has been minimized.

Copy link
Contributor Author

yalh76 commented Jan 12, 2020

Don't you think though that it would be even better with a correct verb, "stopped", "started", and so on ?

I agree with you but it will add some complexity, I tried to make it simple :)

@yalh76 yalh76 mentioned this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.