Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix legacy permission management #868

Merged

Conversation

@kay0u
Copy link
Member

kay0u commented Jan 15, 2020

The problem

The variable unprotected_url or skipped_url used by all our apps will be deprecated after the 3.7. We don't want kill all our apps after the 3.7 upgrade.

Solution

add or remove visitors to mirror what those variables did before 3.7

PR Status

...

How to test

Install an app with a config script that can change the is_public variable (leed for example), and play with the config panel/actions to change the value of is_public:

yunohost app action run leed public_private

Then check permissions with:

yunohost user permission list

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@kay0u kay0u added this to the 3.7.x milestone Jan 22, 2020
Copy link
Contributor

zamentur left a comment

Code review LGTM, untested

Copy link
Contributor

zamentur left a comment

LGTM untested

Copy link
Contributor

zamentur left a comment

we need to check if delete instruction concern the / path. If no we don't want to remove Visitors.

@zamentur zamentur mentioned this pull request Jan 28, 2020
1 of 3 tasks complete
@kay0u

This comment has been minimized.

Copy link
Member Author

kay0u commented Jan 29, 2020

Done

Copy link
Contributor

zamentur left a comment

LGTM

@kay0u kay0u added merging soon™ and removed work needed labels Jan 31, 2020
@Josue-T
Josue-T approved these changes Feb 7, 2020
@kay0u kay0u merged commit f0ef8ac into YunoHost:stretch-unstable Feb 25, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.