Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] options in config panel #873

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@kay0u
Copy link
Member

kay0u commented Jan 25, 2020

The problem

https://forum.yunohost.org/t/issues-with-actions-and-config-panel-features/9773

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/moulinette/interfaces/api.py", line 439, in process
    ret = self.actionsmap.process(arguments, timeout=30, route=_route)
  File "/usr/lib/python2.7/dist-packages/moulinette/actionsmap.py", line 527, in process
    return func(**arguments)
  File "/usr/lib/moulinette/yunohost/log.py", line 287, in func_wrapper
    result = func(*args, **kwargs)
  File "/usr/lib/moulinette/yunohost/app.py", line 1824, in app_config_show_panel
    config_panel = _get_app_config_panel(app)
  File "/usr/lib/moulinette/yunohost/app.py", line 2163, in _get_app_config_panel
    option["ask"] = {"en": option["ask"]}
KeyError: 'ask'

Solution

...

PR Status

...

How to test

Use this config-panel:
https://github.com/YunoHost-Apps/fallback_ynh/blob/2-different-panels/config_panel.toml

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@kay0u kay0u requested review from Psycojoker and maniackcrudelis Jan 25, 2020
@kay0u

This comment has been minimized.

Copy link
Member Author

kay0u commented Jan 26, 2020

Well, in fact with this config panel everything works (without this fix)

I'll wait your feedback before closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.