Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow dots in application name (fix #1525) #888
Described in #1525
Add a literal dot in the regex to validate application names.
Tested by @Gofannon. Seems to fix the issue for them.
Doctests were not run due to my failure at setting up the dev environment. I'll come back to you when i succeed
How to test
Installing and removing an app with a dot in the name should not fail. This can be tried with the
Sounds to me that the problem isn't that dots should be allowed, but on the contrary that dots shouldn't be allowed during the installation.
Agreed. It should be forbidden in the first place.