Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow public apps with no sso tile #894
Not fully tested, any though about it?
How to test
alexAubin left a comment
I suppose it does sort of cover the use case discussed on the forum. On the other hand, as for everything with the permission system, it's touchy because there are plenty of different scenario and use case to consider and everything has to be tested and thought about with precautions ...
I thought about it a bit and it seems okay, but I really can't say for sure that there aren't any piece of code (maybe in
We probably want to update the group permission doc here to advise using
ynh_permission_update --permission "main" --add visitors all_users
instead of just adding visitors, otherwise we're going to have many users finding it weird that the app they just installed does not appear in their sso ...
I'll try this week to update all of my apps with group-permission support. So it will be a good occasion to see if we still have some bug or not.