Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revise format in feature.yml file #60

Merged
merged 3 commits into from Oct 28, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 27, 2023

For an example of how to fill this template out, see this Pull Request in the Wiki.

Description

This PR does the following:

  • Name: Changed from πŸ’‘ Feature Request to Feature Request πŸ’‘. This makes the name more descriptive and easier to find in a list of issues.
  • Description: Changed from Have a new idea/feature to suggest? to Have any new idea or new feature? Share your suggestion with us! :)' This makes the description more engaging and inviting.
  • Labels: Added the enhancement and priority: high labels. This helps to classify the issue and indicate that it is important.
  • Body:
  • Added a Screenshots section. This allows contributors to provide screenshots if they are relevant to the issue.
  • Added a Checklist section. This helps to ensure that contributors have read the contributing guidelines and checked for duplicate issues.
  • Added a no-duplicate-issues checkbox. This makes it easier for contributors to indicate that they have checked for duplicate issues.
  • Changed the extrainfo section to be optional. This reduces the burden on contributors and makes it more likely that they will submit feature requests.

Fixes Issue

Closes #52

Acceptance Criteria

  • Update the content in the feature.yml file
  • If uncertain, compare with the two yml files which are working (bug.yml, other.yml)

Type of Changes

Make sure your code follows the code style of this project.
Make sure your code is up2date.
The title of the PR is the same as the title of the issue.

Type
x πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

issue-template-with-syntax-errors

After

improved version of feature yml file

Testing Steps / QA Criteria

Check the Preview option

@netlify
Copy link

netlify bot commented Oct 27, 2023

βœ… Deploy Preview for accessibility-mentor ready!

Name Link
πŸ”¨ Latest commit f9361c4
πŸ” Latest deploy log https://app.netlify.com/sites/accessibility-mentor/deploys/653c0274a2e83a0008940b4d
😎 Deploy Preview https://deploy-preview-60--accessibility-mentor.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 27, 2023

Hi @YuriDevAT. I made the PR :)

@YuriDevAT
Copy link
Member

Thanks for your contribution πŸ₯³

@YuriDevAT YuriDevAT merged commit d374951 into YurisCodingClub:main Oct 28, 2023
4 of 5 checks passed
@YuriDevAT YuriDevAT added the hacktoberfest-accepted Hacktoberfest contribution label Oct 28, 2023
@CBID2 CBID2 deleted the fixing-the-feature.yml-file branch October 28, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FEATURE issue template does not appear
2 participants