Skip to content
This repository has been archived by the owner on Apr 21, 2024. It is now read-only.

changed duplicate ids for various inputs #36

Merged
merged 1 commit into from Oct 22, 2022
Merged

changed duplicate ids for various inputs #36

merged 1 commit into from Oct 22, 2022

Conversation

utkarsh1311
Copy link
Contributor

@utkarsh1311 utkarsh1311 commented Oct 19, 2022

For an example of how to fill this template out, see this Pull Request in the Wiki.

Description

I have changed the id and name attributes for the required input elements. Now clicking on the label passes the focus to the corresponding input element. Please tell me if any more changes are required.

Related Issue

closes #34

Acceptance Criteria

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

Certain labels had duplicated for attributes which caused the accessibilty issue of multiple labels for the same input .

After

After making changes to the for attributes and name and id attributes for corresponding input elements, clicking on the label passes the focus to the correct input element.

Testing Steps / QA Criteria

  1. Go to the Education form.
  2. Click on any label for the input.
  3. Clicking will make the corresponding input in focus.

@netlify
Copy link

netlify bot commented Oct 19, 2022

βœ… Deploy Preview for dev-cv-ycc ready!

Name Link
πŸ”¨ Latest commit af9c6d0
πŸ” Latest deploy log https://app.netlify.com/sites/dev-cv-ycc/deploys/635026607c011f0008bf3815
😎 Deploy Preview https://deploy-preview-36--dev-cv-ycc.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@YuriDevAT YuriDevAT merged commit 71de782 into YurisCodingClub:main Oct 22, 2022
@YuriDevAT YuriDevAT added the hacktoberfest-accepted Hacktoberfest contribution label Oct 22, 2022
@YuriDevAT
Copy link
Member

Well done, @utkarsh1311. Thank you for your contribution πŸŽ‰

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Education Component Accessibility Issue
2 participants