Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: @Namespace of SwiftUI #187

Merged
merged 1 commit into from May 19, 2022
Merged

support: @Namespace of SwiftUI #187

merged 1 commit into from May 19, 2022

Conversation

YusukeHosonuma
Copy link
Owner

@YusukeHosonuma YusukeHosonuma commented May 19, 2022

As-is

ContentView(
    _namespace: Namespace(id: 83),
    _namespace2: Namespace(id: 84)
)

To be

prettyPrint

ContentView(
    namespace: 83,
    namespace2: 84
)

prettyPrintDebug

ContentView(
    namespace: @Namespace(id: 83),
    namespace2: @Namespace(id: 84)
)

@codecov-commenter
Copy link

Codecov Report

Merging #187 (c927de6) into main (f9594ab) will decrease coverage by 0.42%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   76.42%   76.00%   -0.43%     
==========================================
  Files          13       13              
  Lines         666      675       +9     
==========================================
+ Hits          509      513       +4     
- Misses        157      162       +5     
Impacted Files Coverage Δ
Sources/Core/PrettyDescriber.swift 69.66% <50.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9594ab...c927de6. Read the comment docs.

Copy link
Collaborator

@sahara-ooga sahara-ooga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sahara-ooga sahara-ooga added this to the 1.4.0 - TBD milestone May 19, 2022
@YusukeHosonuma YusukeHosonuma merged commit 58df558 into main May 19, 2022
@YusukeHosonuma YusukeHosonuma deleted the support-namespace branch May 19, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants