Ensure that Z3 uses the correct SMT-LIB2 syntax for push
and pop
#4495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
According to The SMT-LIB Standard Version 2.6, the operators
push
andpop
are defined as follows:That is, they take an unsigned integer value for the number of "assertion levels" to push and pop.
However, if you ask Z3 to dump the SMT2 from the current instance (e.g., using the
logFile
kwarg in Python for aSolver
) then this instance will contain(push)
and(pop)
with no integer arguments.This makes it hard to re-use these SMT-LIB2 instances against other solvers (e.g., to submit benchmarks to SMT-LIB benchmarks) because the instances are not well-formed.
Solution
This PR changes all instance of
(push)
and(pop)
with no arguments to be(push 1)
and(pop 1)
, therefore making the instances usable across other SMT solvers, which are more strict on the syntax they accept.