Bugfix 05 #7
Merged
Bugfix 05 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user provides an input while the list of locally-cached messages is empty. This was caused by updated_messages only becoming defined in the context of either function if the length of list_messages was greater than 0, creating the possibility it is attempted to be returned undefined.
Closes a bug that can cause the monitor applet to crash when encountering network issues during its main operation loop. This was previously a silent crash - now a new error message is displayed and the connection attempts will be halted for 60 seconds before resuming. During such a time menus will be inaccessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses two problems that could lead to crashes of the monitor application:
minorwarning colour scheme and the main operation loop will resume after 60 seconds. This can continue indefinitely until network connectivity is restored (at which point recovery is automatic) or the operator restarts the system. This was issue Unforseen/Undiagnosable crash in Monitor v 1.0.3 #6