Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update URL for MathJax for doxygen #104

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Jun 26, 2024

Description

In the doxygen-generated documenation, rendering MathJax did not work any more (because the CDN hosting the package has gone offline). This is supposed to change to an active CDN - c.f. https://www.mathjax.org/cdn-shutting-down/.

Problem can be seen here
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team June 26, 2024 13:16
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.01%. Comparing base (dedfa6e) to head (3f58a3b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files          85       85           
  Lines       10664    10664           
=======================================
  Hits         7040     7040           
  Misses       3624     3624           
Flag Coverage Δ
windows-latest 66.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose merged commit 4a60e22 into ZEISS:main Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants