Merge pull request mozilla#425 from ochameau/bug/751546-fix-tab-utils…

…-dead-object Bug 751546: Fix "dead object" exception in api-utils/tab/observer. r=@Gozala
ZER0 · May 3, 2012 · 61165fc · 61165fc
2 parents 35cf82a + 9ef15ef
commit 61165fc
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/api-utils/lib/tabs/observer.js b/packages/api-utils/lib/tabs/observer.js
@@ -71,6 +71,12 @@ windowObserver.on("open", onWindowOpen);
 
 function onWindowClose(chromeWindow) {
   if (!isBrowser(chromeWindow)) return; // Ignore if it's not a browser window.
+  // Bug 751546: Emit `deactivate` event on window close immediatly
+  // Otherwise we are going to face "dead object" exception on `select` event
+  if (getActiveTab(chromeWindow) == selectedTab) {
+    observer._emit("deactivate", selectedTab);
+    selectedTab = null;
+  }
   getTabContainers(chromeWindow).forEach(function (container) {
     observer.ignore(container);
   });