Remember me #136

Closed
wants to merge 3 commits into from

6 participants

@Danielss89
ZF-Commons member

Follows the principles of this blog post: http://jaspan.com/improved_persistent_login_cookie_best_practice

It seems that this has some changes from my refactor of the redirect param. Just ignore this.

Notice: Roderik dit not do any of this, it seems that i've commited with his email

@Danielss89
ZF-Commons member

I dont think the names for some of the functions are good. If anyone have some better names just throw them at me!

@pensiero

Any news? How is it going here? I think this is a really important feature and if I can help in some way, even if i don't know a lot, tell me.

@Danielss89
ZF-Commons member

It should be ready to merge. Waiting for @EvanDotPro

@pdobrigkeit

Hey,

I had the same idea that it would be a cool idea to have such an adapter. My approach would have been a little different though. But I just submitted a pull request to make the authentication adapters configurable, which would allow the DB adapter and the Cookie adapter to live side by side. Maybe that would help.

@pdobrigkeit pdobrigkeit and 1 other commented on an outdated diff Oct 12, 2012
src/ZfcUser/Controller/UserController.php
);
}
$form->setData($request->getPost());
if (!$form->isValid()) {
+ die(var_dump($form->getMessages()));

My guess would be this has to be removed ;)

@Danielss89
ZF-Commons member

Haha yeah probably :D wtf..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@pdobrigkeit

Hey Daniel,

i used your pull request as the base to make a drop in module for ZfcUser which offers the remember me functionality. It requires much less changes to the ZfcUser. Maybe you want to check it out?

This pull request would be necessary for the new chains of adapters:
#163

And the module is at:
https://github.com/goalio/GoalioRememberMe

There is still some work to be done, but I think it is a good start and doesn't mess up so much of the original controller code. There are still some things missing, for example it is not checked right away if a cookie is present, but I would move that to either a controller helper or a view helper, because one is not always starting with the login form and still might want to show changes to the UI?

@rubera

Hey!

Really need this functionality. Is it going to be merged?

@pensiero

Pleeease someone merge this pull! Me and my users have to login after few seconds, and it's very tedious :(

@akrabat
ZF-Commons member

@pdobrigkeit's module should now work.

@akrabat akrabat closed this Feb 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment