Fix error because of undefined class constant in src/ZfcUser/Authentication/Adapter/Db.php #201

Merged
merged 1 commit into from Feb 2, 2013

Conversation

Projects
None yet
3 participants
Contributor

hikaru-shindo commented Dec 14, 2012

Fix for issue #198.

The used constant was not defined in the AuthenticationResult so I changed an uncategorized error.

@hikaru-shindo hikaru-shindo Update src/ZfcUser/Authentication/Adapter/Db.php
Fix for issue #198.

The used constant was not defined in the AuthenticationResult so I changed an uncategorized error.
d85e9a7
Contributor

netiul commented Jan 9, 2013

Since the reason of the failure can be categorized, better add a constant AuthenticationResult::FAILURE_INACTIVE.

Contributor

hikaru-shindo commented Jan 9, 2013

AuthenticationResult is in reality Zend\Authentication\Result which can't be altered by the module. In this regard I think AuthenticationResult::FAILURE_UNCATEGORIZED does represent the error best. If we would set our own status code (eg -99) it would be set to AuthenticationResult::FAILURE (which is at the moment 0)

A nice message is already shown without it. It's not nice to be translated through...

Contributor

netiul commented Jan 9, 2013

You are right! Sorry about my comment!

Contributor

hikaru-shindo commented Jan 10, 2013

There is nothing to be sorry about. Nobody is perfect - including me ;)

@akrabat akrabat added a commit that referenced this pull request Feb 2, 2013

@akrabat akrabat Merge pull request #201 from hikaru-shindo/patch-1
Fix error because of undefined class constant in src/ZfcUser/Authentication/Adapter/Db.php
4af0ec9

@akrabat akrabat merged commit 4af0ec9 into ZF-Commons:master Feb 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment