Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve promise on close event #137

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@ZJONSSON
Copy link
Owner

ZJONSSON commented Jun 17, 2019

closes #136

The finish event of the duplex stream can fire before the writers are done. The close event is only fired when we are done writing

  • Resolve promise on close event
  • Amend test to use promise (would fail without the fix)
Amend test to use promise (would fail without the fix)
@ZJONSSON ZJONSSON merged commit a4307bb into master Jun 17, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ZJONSSON ZJONSSON deleted the fix-extract-close branch Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.